orderwatch: Update lastUpdated and fillableTakerAssetAmount for order in DB #386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabioberger
force-pushed
the
fix/missingLastUpdatedUpdates
branch
from
0166385
to
ab68140
Compare
albrow
suggested changes
Sep 3, 2019
fabioberger
force-pushed
the
fix/missingLastUpdatedUpdates
branch
from
ab68140
to
75268a9
Compare
…idate it, not only if it's added/removed from the OrderWatcher
fabioberger
force-pushed
the
fix/missingLastUpdatedUpdates
branch
from
75268a9
to
4c04415
Compare
…that no one else can modify the orders while the orders are being read and modified by this method
albrow
suggested changes
Sep 5, 2019
|
@fabioberger I think you meant to pass the transaction through to |
…lso encompasses the order reads, not just the writes
fabioberger
force-pushed
the
fix/missingLastUpdatedUpdates
branch
from
03d8783
to
15b83b8
Compare
albrow
approved these changes
Sep 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #190
Currently, we aren't updating an orders
fillableTakerAssetAmountnor it'slastUpdatedtimestamp in the DB when processing a contract event impacting it unless it is being unwatched or re-watched. This PR makes it such that we always update an order's DB entry, no matter what the event so that thelastUpdatedandfillableTakerAssetAmountin the DB is always accurate.